Update updating.md #642
Closed
Update updating.md #642
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The documentation is slightly misleading in the supported php versions. It correctly states to use 8.2 or 8.3 at the top of the page, but scrolling down it says ''...running atleast 8.2'' indicating that 8.4 might also be supported (which it isn't)
rowansc1
requested changes
Jan 26, 2025
| @@ -34,8 +34,8 @@ There are no 1.8.x, 1.9.x, or 1.10.x releases of Wings. | |||
| - PHP `8.2`, or `8.3` (recommended) | |||
| - Composer `2.X` | |||
|
|
|||
| **Before continuing**, please ensure that your system and web server configuration has been upgraded to at least PHP 8.2 by running `php -v` and Composer 2 by running `composer --version`. You | |||
| should see an output similar to the result below. If you do not see at least PHP 8.2 and Composer 2, you will need to upgrade by following | |||
| **Before continuing**, please ensure that your system and web server configuration has been upgraded to at least PHP 8.2 or 8.3 by running `php -v` and Composer 2 by running `composer --version`. You | |||
There was a problem hiding this comment.
"at least PHP 8.2 or 8.3" still implies that PHP 8.4 is supported. Could you reword this?
There was a problem hiding this comment.
Actually, it might be worth following the same method as in #625. That would future proof this from being incorrect in the future.
| **Before continuing**, please ensure that your system and web server configuration has been upgraded to at least PHP 8.2 by running `php -v` and Composer 2 by running `composer --version`. You | ||
| should see an output similar to the result below. If you do not see at least PHP 8.2 and Composer 2, you will need to upgrade by following | ||
| **Before continuing**, please ensure that your system and web server configuration has been upgraded to at least PHP 8.2 or 8.3 by running `php -v` and Composer 2 by running `composer --version`. You | ||
| should see an output similar to the result below. If you do not see at least PHP 8.2 or 8,3 and Composer 2, you will need to upgrade by following |
rowansc1
added
enhancement
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The documentation is slightly misleading in the supported php versions. It correctly states to use 8.2 or 8.3 at the top of the page, but scrolling down it says ''...running atleast 8.2'' indicating that 8.4 might also be supported (which it isn't)
Changed it to say ''...running atleast 8.2 or 8.3'' to avoid some confusion
Thanks to https://github.com/DataDropp for noticing it