Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

feat: make MutableItem de/serializable #45

Merged
merged 1 commit into from
Dec 13, 2024
Merged

Conversation

mikedilger
Copy link
Contributor

@mikedilger mikedilger commented Dec 13, 2024

I have this idea of creating the MutableItem with my private key on an offline device, serializing it to a file on a USB key, and then using an online device to push it into the DHT, so as to keep the private key offline. This requires serde on the MutableItem.

@Nuhvi
Copy link
Collaborator

Nuhvi commented Dec 13, 2024

Makes sense and seems to be a free feature. The only reason we never needed that is because pkarr::SignedPacket handles that use case.

@Nuhvi Nuhvi merged commit 4c8d8e2 into pubky:main Dec 13, 2024
1 check passed
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants