Skip to content

update reqwest features to use rustls #182

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom
Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

update reqwest features to use rustls #182

wants to merge 2 commits into from

Conversation

CodyPubNub
Copy link

Switches reqwest from using openssl to instead use rustls

@CodyPubNub
update reqwest features to use rustls
d98caa2 
Signed-off-by: Cody Carlsen <cody@pubnub.com>
Xavrax
Xavrax approved these changes Jan 19, 2024
View reviewed changes
Copy link
Contributor

@Xavrax Xavrax left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Xavrax
Copy link
Contributor

Xavrax commented Jan 19, 2024

We will merge the changes when the new clippy tool rules are satisfied by the master branch.

@Xavrax Xavrax added priority: low This PR should be reviewed after all high and medium PRs. status: done This issue is considered resolved. type: build This PR contains changes to the build system (like Travis or publishing a package). labels Jan 19, 2024
@parfeon
Copy link
Contributor

parfeon commented Jan 22, 2024

We will push this with upcoming release with event listeners.

@parfeon
Copy link
Contributor

parfeon commented Jan 26, 2024

@CodyPubNub looks like our linters won't pass this PR.

  • ring which is used by rustls doesn't have a license - not allowed
  • rustls-webpki and untrusted has ISC which, in the current configuration, explicitly not allowed. Is it ok for MIT projects?

# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@stephenlb stephenlb stephenlb approved these changes

@Xavrax Xavrax Xavrax approved these changes

@parfeon parfeon Awaiting requested review from parfeon parfeon is a code owner

@seba-aln seba-aln Awaiting requested review from seba-aln seba-aln is a code owner

Assignees
No one assigned
Labels
priority: low This PR should be reviewed after all high and medium PRs. status: done This issue is considered resolved. type: build This PR contains changes to the build system (like Travis or publishing a package).
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@CodyPubNub @Xavrax @parfeon @stephenlb