Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

systems/cva6_desc: Various fixes #26

Closed
wants to merge 1 commit into from

Conversation

iburaky-ids
Copy link

dma_desc_wrap.sv:

  • idma_backend's axi_req* and axi_rsp* were changed to protocol_req* and protocol_rsp* in b9d7f04 , but the same changes were not made to dma_desc_wrap.sv, this is now fixed
  • RepWidth and StrideWidth are undefined, and unless I missed something in the macros, reps_t and strides_t are not used, therefore those lines are now removed

dma_reg_to_axi.sv:

  • Verilog does not require a backslash to break lines of code and I get an error in QuestaSim with the backslash

@iburaky-ids iburaky-ids requested a review from micprog as a code owner April 21, 2023 15:11
@thommythomaso
Copy link
Collaborator

Thank you for your contributions. Merged as part of PR #36. Closed.

thommythomaso added a commit that referenced this pull request Oct 26, 2023
* frontend: Create a dataflow-oriented descriptor-based iDMA frontend supporting prefetching. #18

* systems/cva6_desc: Various fixes #26

---------

Co-authored-by: Axel Vanoni <axvanoni@ethz.ch>

Co-authored-by: iburaky-ids
thommythomaso added a commit that referenced this pull request Oct 26, 2023
* frontend: Create a dataflow-oriented descriptor-based iDMA frontend supporting prefetching. #18

* systems/cva6_desc: Various fixes #26

---------

Co-authored-by: Axel Vanoni <axvanoni@ethz.ch>

Co-authored-by: iburaky-ids
thommythomaso added a commit that referenced this pull request Oct 27, 2023
* frontend: Create a dataflow-oriented descriptor-based iDMA frontend supporting prefetching. #18

* systems/cva6_desc: Various fixes #26

---------

Co-authored-by: Axel Vanoni <axvanoni@ethz.ch>

Co-authored-by: iburaky-ids
thommythomaso added a commit that referenced this pull request Oct 27, 2023
* frontend: Create a dataflow-oriented descriptor-based iDMA frontend supporting prefetching. #18

* systems/cva6_desc: Various fixes #26

---------

Co-authored-by: Axel Vanoni <axvanoni@ethz.ch>

Co-authored-by: iburaky-ids
thommythomaso added a commit that referenced this pull request Oct 27, 2023
* frontend: Create a dataflow-oriented descriptor-based iDMA frontend supporting prefetching. #18

* systems/cva6_desc: Various fixes #26

* tracer: Add an inital version of the tracer - derived from #9

---------

Co-authored-by: Axel Vanoni <axvanoni@ethz.ch>
Co-authored-by: iburaky-ids
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants