Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Add pulp_labels to Content. #5787

Merged
merged 1 commit into from
Feb 25, 2025
Merged

Add pulp_labels to Content. #5787

merged 1 commit into from
Feb 25, 2025

Conversation

ggainey
Copy link
Contributor

@ggainey ggainey commented Sep 11, 2024

No description provided.

@ggainey ggainey requested a review from mdellweg September 11, 2024 14:03
@ggainey
Copy link
Contributor Author

ggainey commented Sep 11, 2024 •
edited
Loading

Note that RBAC support for set/unset-labels requires work in the plugins - see the pulp_file commit.

Current issues:

  • upload file needs multipart, pulp_labels needs JSON dict, and DRF is Sad about tat combination
  • tests
  • search-by-label-and-repo(s)
  • remove-by-label-and-repo(s) (will be future work)

@ggainey ggainey force-pushed the label_content branch 2 times, most recently from c23fc71 to 988f062 Compare September 12, 2024 20:20
@stale Stale
Copy link

stale bot commented Dec 18, 2024

This pull request has been marked 'stale' due to lack of recent activity. If there is no further activity, the PR will be closed in another 30 days. Thank you for your contribution!

@stale stale bot added the stale label Dec 18, 2024
@ggainey ggainey removed the stale label Dec 18, 2024
@ggainey ggainey changed the title DRAFT pulp_labels POC Add pulp_labels to Content. Feb 25, 2025
@ggainey ggainey force-pushed the label_content branch 4 times, most recently from fd9af14 to df71162 Compare February 25, 2025 03:27
@ggainey ggainey marked this pull request as ready for review February 25, 2025 03:57
mdellweg
mdellweg previously approved these changes Feb 25, 2025
View reviewed changes
dkliban
dkliban requested changes Feb 25, 2025
View reviewed changes
Copy link
Member

@dkliban dkliban left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for this wonderful feature! Please add a test that uses the generic Content API to perform filtering my pulp_label.

@ggainey ggainey marked this pull request as draft February 25, 2025 15:12
@ggainey ggainey marked this pull request as ready for review February 25, 2025 16:18
@ggainey
Add pulp_labels to Content.
2306e20 
Uses the same approach used by Repository, Distribution, and Remote.

closes pulp#3338.
@ggainey ggainey merged commit fb999d9 into pulp:main Feb 25, 2025
12 checks passed
This was referenced Feb 25, 2025
Closed
Open
@ggainey ggainey mentioned this pull request Mar 5, 2025
Open
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@dkliban dkliban dkliban approved these changes

@mdellweg mdellweg mdellweg left review comments

@gerrod3 gerrod3 Awaiting requested review from gerrod3

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ggainey @dkliban @mdellweg @gerrod3