Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Add deb-get to downloads page #210

Merged
merged 2 commits into from
Jun 24, 2023
Merged

Conversation

Daeraxa
Copy link
Member

@Daeraxa Daeraxa commented May 10, 2023

This PR is ready for review but I'm marking as draft as I don't want to make this official until the deb-get maintainers fix a bug with Linux Mint as we really don't want to taint this for users who might come to us for help as the ones promoting it

Based on the results of this poll this adds deb-get as an official distribution method for Pulsar.

There are a few of changes here:

  • Added a new section to the Linux regular release section in the same format (+ distro info) as the Windows one
  • Changed the table width CSS rule from width to max-width and min-width as this one was wrapping and just extending all the tables looked weird with the extra whitespace.
  • Added an info box to the linux rolling section saying that package manager installs are only currently available for regular releases.

@Daeraxa Daeraxa marked this pull request as draft May 10, 2023 22:51
@Daeraxa
Copy link
Member Author

Daeraxa commented Jun 15, 2023

This issue has finally been resolved with wimpysworld/deb-get#829 so I can mark this as ready now.

@Daeraxa Daeraxa marked this pull request as ready for review June 15, 2023 18:05
Copy link
Member

@Spiker985 Spiker985 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All documentation - looks good to me

Copy link
Member

@confused-Techie confused-Techie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fantastic!

I wonder, and I'm sorry if we discussed this, but would be interesting to investigate trying to support rolling releases here. But if memory serves that may have been against their terms? If not I'd be happy to brainstorm some way to accomplish this

@Daeraxa
Copy link
Member Author

Daeraxa commented Jun 24, 2023

So ARM is now working again so we can finally merge this lol.

I wonder, and I'm sorry if we discussed this, but would be interesting to investigate trying to support rolling releases here.

I don't think it is against it and it was something I was looking at (and was struggling with) but totally forgot - the problem is that we need to be able to store the version info so that deb-get knows there is an upgrade - so that means we have to use the "unwrapped" URL.

e.g. the current x86 deb link is https://download.pulsar-edit.dev/?os=linux&type=linux_deb but we can't use that directly and would instead need to be able to reference the "unwrapped" URL - https://api.cirrus-ci.com/v1/artifact/task/4815644680519680/binary/binaries/pulsar_1.106.2023062118_amd64.deb

If anyone wants to have a look, the scripts are pretty simple:
https://github.com/wimpysworld/deb-get/blob/main/EXTREPO.md

@Daeraxa Daeraxa merged commit 5ae445f into pulsar-edit:main Jun 24, 2023
@Daeraxa Daeraxa deleted the add-deb-get branch June 24, 2023 13:49
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants