Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Dashboards are unusable again #3562

Closed
jirikopecky opened this issue Sep 5, 2024 · 1 comment · Fixed by #3566
Closed

Dashboards are unusable again #3562

jirikopecky opened this issue Sep 5, 2024 · 1 comment · Fixed by #3566
Assignees
Labels
customer/feedback Feedback from customers impact/regression Something that used to work, but is now broken kind/bug Some behavior is incorrect or out of spec p1 A bug severe enough to be the next item assigned to an engineer resolution/fixed This issue was fixed
Milestone

Comments

@jirikopecky
Copy link

What happened?

Release 2.48.0 allowed creation of Azure Portal dashboards by treating part metadata as untyped JSON. This was a workaround around Azure API spec issue Azure/azure-rest-api-specs#27465.

We started porting our dashboard definitions from custom ARM template deployment initiated by Pulumi to Pulumi, but before we could finish this work this workaround was removed in release 2.54.0. Now only Markdown parts can be created by Pulumi again, which not only prevents us from creating dashboards in Pulumi but also means that we cannot use refresh for drift detection as any time we do refresh & up Pulumi tries to delete the content of dashboard.

Please consider putting the workaround back.

Original issues: #3015, #3023

Example

Examples provided in original issues.

Output of pulumi about

CLI
Version      3.131.0
Go Version   go1.23.0
Go Compiler  gc

Plugins
KIND      NAME          VERSION
resource  azure-native  2.59.0
resource  cloudflare    5.37.1
language  dotnet        unknown
resource  random        4.16.3
resource  tls           5.0.4

Host
OS       darwin
Version  14.6.1
Arch     arm64

This project is written in dotnet: executable='/opt/homebrew/bin/dotnet' version='8.0.401'

Additional context

No response

Contributing

Vote on this issue by adding a 👍 reaction.
To contribute a fix for this issue, leave a comment (and link to your pull request, if you've opened one already).

@jirikopecky jirikopecky added kind/bug Some behavior is incorrect or out of spec needs-triage Needs attention from the triage team labels Sep 5, 2024
@mikhailshilkov mikhailshilkov added p1 A bug severe enough to be the next item assigned to an engineer impact/regression Something that used to work, but is now broken customer/feedback Feedback from customers labels Sep 6, 2024
@mikhailshilkov mikhailshilkov removed the needs-triage Needs attention from the triage team label Sep 11, 2024
@mjeffryes mjeffryes added this to the 0.110 milestone Sep 12, 2024
@pulumi-bot pulumi-bot added the resolution/fixed This issue was fixed label Sep 17, 2024
@pulumi-bot
Copy link
Contributor

This issue has been addressed in PR #3566 and shipped in release v2.62.0.

danielrbradley added a commit that referenced this issue Sep 30, 2024
Add a more understandable and unified approach to modifying existing
parts of the schema.

Use a function to define a resource's schema–resource & types in both
the schema and metadata. This is given any existing declaration which it
is allowed to modify.

- If newly added types conflict with an existing type in the schema, we
will raise an error.
- Allows modifying any of the types associated with the custom resource.
- Allow modification of both the schema and the metadata in one
abstration.
- Allows creation of brand new resources - the existing resource will
just be nil.

This allows the removal of the custom resource `Types`, `Schema` and
`Meta` fields along with the associated `SchemaMixins`,
`SchemaTypeMixins` and `MetaMixins` functions.

## Dashboard Fix

Re-implements #3123
after it was reverted in
#3500 due to breaking
our ability to release.

Fixes #3562
Fixes pulumi/customer-support#1737

This then re-implements the portal Dashboard customisations, but rather
than blindly overwriting the existing schema elements, it manipulates
specific fields as required, giving opportunity for error handling if
the expected types or fields don't match.
@pulumi pulumi deleted a comment from pulumi-bot Sep 30, 2024
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
customer/feedback Feedback from customers impact/regression Something that used to work, but is now broken kind/bug Some behavior is incorrect or out of spec p1 A bug severe enough to be the next item assigned to an engineer resolution/fixed This issue was fixed
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants