Update to latest deps and make runable #2
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lukehoban
approved these changes
May 2, 2020
| _, err = k.azureGet(ctx, id) | ||
| if resErr, ok := err.(azure.RequestError); ok && resErr.StatusCode == 404 { | ||
| _, err = k.azureGet(ctx, id, res.apiVersion) | ||
| if err == nil { | ||
| return nil, fmt.Errorf("cannot create already existing resource %v", id) |
There was a problem hiding this comment.
Why do we return his on err == nil now?
There was a problem hiding this comment.
- We are in
Create, trying to check whether the resource-to-be-created already exists. - We make a
GETon its endpoint - If we get no error, that means 200, that means it already exists.
- We can't create it => error.
I think it used to "work" because the type conversion was wrong.
thomas11
added a commit
that referenced
this pull request
Jan 8, 2025
Skip the flattening of nested properties indicated by [x-ms-client-flatten](https://github.com/Azure/autorest/blob/main/docs/extensions/readme.md#x-ms-client-flatten) if it would lead to overwriting a property, creating incorrect schema and SDKs. This case happens when inner and outer property have the same name. For a report on all occurrences see #3013. This change is breaking and could therefore only be applied to v3 of the provider. The PR is written to be reviewed commit by commit. It supersedes the previous #3801. **I recommend hiding whitespace when reviewing since the level of indentation of otherwise unaffected code changed.** Resolves #3195
|
This PR has been shipped in release v2.82.0. |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
azCLI