Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Add exception for CIAMResourceSKU tier schemagen #3559

Merged
merged 3 commits into from
Sep 5, 2024

Conversation

thomas11
Copy link
Contributor

@thomas11 thomas11 commented Sep 5, 2024

CIAMResourceSKU has two properties name and tier. The latter is incorrectly annotated with x-ms-client-flatten, causing it to be missing from CIAMResourceSKU in the Pulumi schema. See upstream issue Azure/azure-rest-api-specs#30443 for more detail.

This PR adds an unfortunate hard-coded exception to unblock the CIAMResource resource.

Fixes #3556

@thomas11 thomas11 requested review from danielrbradley and a team September 5, 2024 07:16
Copy link

github-actions bot commented Sep 5, 2024

Does the PR have any schema changes?

Found 2 breaking changes:

Types

  • 🟢 "azure-native:azureactivedirectory:CIAMResourceSKU": required: "tier" property has changed to Required
  • 🟢 "azure-native:azureactivedirectory:CIAMResourceSKUResponse": required: "tier" property has changed to Required
    No new resources/functions.

Copy link

codecov bot commented Sep 5, 2024

Codecov Report

Attention: Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.

Project coverage is 57.80%. Comparing base (9be66cd) to head (4fdfdd5).
Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
provider/pkg/gen/properties.go 0.00% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3559      +/-   ##
==========================================
+ Coverage   57.79%   57.80%   +0.01%     
==========================================
  Files          66       66              
  Lines        8284     8286       +2     
==========================================
+ Hits         4788     4790       +2     
  Misses       3050     3050              
  Partials      446      446              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@danielrbradley danielrbradley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the workaround is reasonable - pretty self-contained and documented which is the best we can hope for here. Is there any way to also scope this to the module/version at all or is that not available in this context?

@thomas11 thomas11 force-pushed the tkappler/ciamresource-tier branch from e420e80 to 4fdfdd5 Compare September 5, 2024 10:03
@thomas11 thomas11 enabled auto-merge (squash) September 5, 2024 10:03
@thomas11 thomas11 merged commit 215450f into master Sep 5, 2024
22 of 23 checks passed
@thomas11 thomas11 deleted the tkappler/ciamresource-tier branch September 5, 2024 10:36
@pulumi-bot
Copy link
Contributor

This PR has been shipped in release v2.60.0.

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CIAMTenant creation requires a non-supported Tier attribute
3 participants