-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Add exception for CIAMResourceSKU tier schemagen #3559
Conversation
Does the PR have any schema changes?Found 2 breaking changes: Types
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #3559 +/- ##
==========================================
+ Coverage 57.79% 57.80% +0.01%
==========================================
Files 66 66
Lines 8284 8286 +2
==========================================
+ Hits 4788 4790 +2
Misses 3050 3050
Partials 446 446 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the workaround is reasonable - pretty self-contained and documented which is the best we can hope for here. Is there any way to also scope this to the module/version at all or is that not available in this context?
e420e80
to
4fdfdd5
Compare
This PR has been shipped in release v2.60.0. |
CIAMResourceSKU has two properties
name
andtier
. The latter is incorrectly annotated withx-ms-client-flatten
, causing it to be missing fromCIAMResourceSKU
in the Pulumi schema. See upstream issue Azure/azure-rest-api-specs#30443 for more detail.This PR adds an unfortunate hard-coded exception to unblock the
CIAMResource
resource.Fixes #3556