Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Correctly generate "Prior API version" text #3889

Merged
merged 1 commit into from
Jan 25, 2025
Merged

Correctly generate "Prior API version" text #3889

merged 1 commit into from
Jan 25, 2025

Conversation

EronWright
Copy link
Contributor

Updates the generated package description to be correct for 3.x, while also being compatible with 2.x.

In 2.x, the generated code is unchanged. In 3.x:

-Azure REST API version: 2023-02-01. Prior API version in Azure Native 1.x: 2020-11-01.
+Azure REST API version: 2023-02-01. Prior API version in Azure Native 2.x: 2020-11-01.

After merging, we'll cherry-pick to v3 branch and regenerate the SDKs.

Fixes #3866

@EronWright EronWright added the impact/no-changelog-required This issue doesn't require a CHANGELOG update label Jan 24, 2025
Copy link

Does the PR have any schema changes?

Looking good! No breaking changes found.
No new resources/functions.

Copy link

codecov bot commented Jan 24, 2025

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 57.26%. Comparing base (58661c2) to head (4b138cb).
Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
provider/pkg/gen/schema.go 0.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##           master    #3889   +/-   ##
=======================================
  Coverage   57.26%   57.26%           
=======================================
  Files          78       78           
  Lines       12438    12438           
=======================================
  Hits         7122     7122           
  Misses       4769     4769           
  Partials      547      547           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@thomas11 thomas11 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice and simple!

@EronWright EronWright merged commit 7d76160 into master Jan 25, 2025
24 checks passed
@EronWright EronWright deleted the issue-3866 branch January 25, 2025 21:05
@thomas11 thomas11 mentioned this pull request Jan 29, 2025
@pulumi-bot
Copy link
Contributor

This PR has been shipped in release v2.85.0.

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
impact/no-changelog-required This issue doesn't require a CHANGELOG update
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update previous version in descriptions
3 participants