Manually pin Container instance for v3 #3912
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Only ContainerGroup and ContainerGroupProfile are actually listed as live. - The latest live version with both resources is 2024-05-01-preview so we'll track that for v3. - Exclude the NGroup resource as it's not live and causes conflicts for now. This lets us remove the manual type merging override.
Does the PR have any schema changes?Looking good! No breaking changes found. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #3912 +/- ##
==========================================
- Coverage 57.04% 57.03% -0.01%
==========================================
Files 79 79
Lines 12549 12549
==========================================
- Hits 7158 7157 -1
- Misses 4840 4841 +1
Partials 551 551 ☔ View full report in Codecov by Sentry. |
thomas11
approved these changes
Jan 30, 2025
There was a problem hiding this comment.
2024-05 is also what the latest beta of the Go SDK uses (via). Latest stable is still on 2023-05, though.
|
This PR has been shipped in release v2.86.0. |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This lets us remove the manual type merging override.