(BOLT-1403) Make bolt-server specs less task-specific #1059
Conversation
| # Since this will only be on one node we can just return the first result | ||
| result = scrub_stack_trace(results.first.status_hash) | ||
| [200, result.to_json] | ||
| @executor.run_task(target, task, parameters) |
There was a problem hiding this comment.
Moving the HTTP response details to the caller here seemed like a simple way to make run_task more focused on just the task operations, but open to changing this
| } | ||
|
|
||
| post path, JSON.generate(body), 'CONTENT_TYPE' => 'text/json' | ||
| context 'when raising errors' do |
There was a problem hiding this comment.
I moved these app-wide test cases further up, above the transport-specific and action-specific tests. I also removed the task body content passed to this 404 test case, since they should never reach validation anyway .
| end | ||
| end | ||
|
|
||
| describe 'transport routes' do |
There was a problem hiding this comment.
My goal with moving these test cases to a "transport routes" section was to unit test the /ssh/:action and /winrm/:action logic without making the test content specific to one action. These tests no longer use the :ssh or :winrm tags because the functions they call have been mocked. FWIW, there are actual echo task executions for ssh and winrm further down, but if we'd rather actually run these in the docker/vagrant environment, I can take this back to the drawing board.
There was a problem hiding this comment.
Since there are executions of actual ssh/winrm further down I think there's a low level of risk in your approach here. 👍
| } | ||
| } | ||
| } | ||
| describe 'action endpoint' do |
There was a problem hiding this comment.
My intent is to use this section for testing of other endpoints like run_command, run_script, or upload_file.
caseywilliams
force-pushed
the
BOLT-1403/spec-refactor
branch
from
bd7a9a9 to
be0b943
Compare
|
😟 I'm not sure I understand why there's a connection failure in appveyor -- the same test seems to be passing for me locally with vagrant |
|
CLA signed by all contributors. |
Refactors transport_app_spec tests in a way that should allow for easier additions of other actions (like run_command, upload_file, run_script) to the bolt server API alongside run_task. app_integration_spec tests remain the same, except for a renamed helper method.
caseywilliams
force-pushed
the
BOLT-1403/spec-refactor
branch
from
be0b943 to
f3ba7a7
Compare
|
Hmm, now Appveyor is passing, but Travis is failing on docs generation -- I'm not sure what's up, since it was passing before |
|
Uhh, my best guess is the newest yard gem release changes how puppet-strings works? Put up #1061 but I want to verify that we actually want it. Sorry! Update: We went with pinning yard #1062 until we fix in puppet-strings puppetlabs/puppet-strings#205 so you should be good to go. |
Refactors transport_app_spec tests in a way that should allow for easier
additions of other actions (like run_command, upload_file, run_script)
to the bolt server API alongside run_task.
app_integration_spec tests remain the same, except for a renamed helper
method.