Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

(GH-122) Fix bad detection of optional parameters out of order #123

Merged
merged 1 commit into from
Jun 9, 2023
Merged

(GH-122) Fix bad detection of optional parameters out of order #123

merged 1 commit into from
Jun 9, 2023

Conversation

tiandrey
Copy link

@tiandrey tiandrey commented May 4, 2023

  • Fixed optional parameters definition
  • Added support for custom types
  • Fixed doc URL and a typo
  • Added and fixed tests

@tiandrey tiandrey requested a review from a team as a code owner May 4, 2023 19:27
@CLAassistant
Copy link

CLAassistant commented May 4, 2023 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@tiandrey tiandrey force-pushed the fix-optional-params branch 2 times, most recently from e1621c3 to bde18e7 Compare May 5, 2023 07:53
@tiandrey
Copy link
Author

@chelnak , can you please have a look at this PR and linked issue?

@chelnak chelnak force-pushed the fix-optional-params branch from bde18e7 to ddee8cc Compare June 9, 2023 20:34
@chelnak chelnak requested a review from bastelfreak as a code owner June 9, 2023 20:34
@chelnak chelnak merged commit c12c5f4 into puppetlabs:main Jun 9, 2023
@chelnak
Copy link

chelnak commented Jun 9, 2023

@tiandrey Thank you!

@chelnak chelnak changed the title Fix #122 (GH-122) Fix bad detection of optional parameters out of order Jun 9, 2023
@chelnak chelnak added the bug Something isn't working label Jun 9, 2023
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@chelnak chelnak chelnak approved these changes

@bastelfreak bastelfreak Awaiting requested review from bastelfreak bastelfreak is a code owner

Assignees
No one assigned
Labels
bug Something isn't working community
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@tiandrey @CLAassistant @chelnak @ia-content