Fix assertion when rspec-json_expectations is missing #75
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In 21f5743 the output was changed and the code path when rspec-json_expectations is present was updated, but not without. While this is an odd code path (since Gemfile does declare it as a dependency), it can be hit if a different dependency mechanism is used and the expectations should be correct. Fixes: 21f5743
chelnak
approved these changes
Jan 16, 2023
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In 21f5743 the output was changed and the code path when rspec-json_expectations is present was updated, but not without. While this is an odd code path (since Gemfile does declare it as a dependency), it can be hit if a different dependency mechanism is used (in particular: run the test suite in RPM's %check phase with explicit BuildRequires) and the expectations should be correct.
Fixes: 21f5743