Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

(CONT-1193) - Add --providers and --list-providers flags #357

Merged
merged 3 commits into from
Jul 3, 2023

Conversation

jordanbreen28
Copy link
Contributor

@jordanbreen28 jordanbreen28 commented Jul 3, 2023

Summary

This PR finishes the implementation of the providers flag as this was never completed.
It also adds a new flag that can be used to list all available providers and their respective types within the module.

Additional Context

adding --providers to a describe command i.e. describe firewall --providers, returns the providers for the firewall type.
image

running --list-providers lists all providers in the module.
image

Checklist

  • 🟢 Spec tests.
  • 🟢 Acceptance tests.
  • Manually verified.

This commit introduces a fix that now allows the describe providers
command to work.

It also adds a null check before executing `each` on the describe_types
variable as before this would result in unknown function each for
Nil:Nil Class.
@jordanbreen28 jordanbreen28 requested a review from a team as a code owner July 3, 2023 17:00
This commit completes the unfinished work to add logic for the --provider and --list-provider flags
@jordanbreen28 jordanbreen28 force-pushed the CONT-1193-finish_providers_implementation branch from 6f3e8d3 to 3e1b641 Compare July 3, 2023 17:03
@chelnak
Copy link
Contributor

chelnak commented Jul 3, 2023

Fantastic stuff! Thanks @jordanbreen28 🙏

@chelnak chelnak merged commit afe7515 into main Jul 3, 2023
@chelnak chelnak deleted the CONT-1193-finish_providers_implementation branch July 3, 2023 17:32
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants