validate: give hint on how to regenerate outdated REFERENCE.md #388
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #388 +/- ##
=======================================
Coverage 70.91% 70.91%
=======================================
Files 78 78
Lines 2486 2486
=======================================
Hits 1763 1763
Misses 723 723 ☔ View full report in Codecov by Sentry. |
bastelfreak
reviewed
Feb 27, 2024
| @@ -34,7 +34,7 @@ | |||
| existing = File.read(filename) | |||
|
|
|||
| if generated != existing | |||
| warn "#{filename} is outdated" | |||
| warn "#{filename} is outdated; to regenerate: bundle exec rake strings:generate:reference" | |||
There was a problem hiding this comment.
I am wondering how many people might call puppet strings not via bundler 🤔 but I am +1 for the change
bastelfreak
approved these changes
Feb 27, 2024
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the command we use with @voxpupuli modules (ref), not sure what the correct way is for PDK modules.