Only add ssh options to commands that actually talk to the network. #121
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -92,7 +92,7 @@ def clone_repository(revision) | |||
| end | |||
| args.push(@resource.value(:source), | |||
| @resource.value(:path)) | |||
| hg_wrapper(*args) | |||
| hg_wrapper(*args, :remote => true) | |||
There was a problem hiding this comment.
You may need to wrap the second parameter in curly braces for Ruby 1.8.7 compatibility: hg_wrapper(*args, {:remote => true})
|
Seems so. I guess the legacy replacement for keyword arguments that I used was not quite legacy enough. |
|
May still want to squash the commits and add the explanations to a single commit message instead. |
At least in Mercurial 2.8.2, --ssh seems to be a command-specific parameter in
contrast to a global one. As a result, local commands error when seeing a --ssh
parameter. This change passes --ssh only for commands that actually talk to the
network ('incoming', 'pull' and 'clone' here).
|
Alright, this it? I'm not too familiar with this workflow. |
| @@ -92,6 +92,7 @@ def clone_repository(revision) | |||
| end | |||
| args.push(@resource.value(:source), | |||
| @resource.value(:path)) | |||
| args.push({ :remote => true }) | |||
| hg_wrapper(*args) | |||
There was a problem hiding this comment.
Oh, did hg_wrapper(*args, {:remote => true}) not work after all? Your solution is a reasonable workaround. Thanks for updating your commit!
|
(By the way, yes you got the rebase workflow correctly!) |
apenney
pushed a commit
that referenced
this pull request
Apr 3, 2014
Only add ssh options to commands that actually talk to the network.
cegeka-jenkins
pushed a commit
to cegeka/puppet-vcsrepo
that referenced
this pull request
Jan 3, 2018
Only add ssh options to commands that actually talk to the network.
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
At least in Mercurial 2.8.2, --ssh seems to be a command-specific parameter in contrast to a global one. As a result, local commands error when seeing a --ssh parameter. This change passes --ssh only for commands that actually talk to the network ('incoming', 'pull' and 'clone' here).