(MODULES-9997) - Removing extra unwrap on Sensitive value #490
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pmcmaw
force-pushed
the
MODULES-9997/main/removing-sensitive-wrap
branch
from
c35b6b0 to
48626bf
Compare
Codecov Report
@@ Coverage Diff @@
## main #490 +/- ##
=======================================
Coverage 72.88% 72.88%
=======================================
Files 10 10
Lines 1088 1088
=======================================
Hits 793 793
Misses 295 295
Continue to review full report at Codecov.
|
pmcmaw
force-pushed
the
MODULES-9997/main/removing-sensitive-wrap
branch
2 times, most recently
from
2f69fb2 to
e738139
Compare
pmcmaw
force-pushed
the
MODULES-9997/main/removing-sensitive-wrap
branch
from
e738139 to
d39fe15
Compare
pmcmaw
force-pushed
the
MODULES-9997/main/removing-sensitive-wrap
branch
from
9f40273 to
df0142d
Compare
sanfrancrisko
approved these changes
Feb 16, 2021
DavidS
approved these changes
Feb 16, 2021
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removing unwrap. When it is called, unwrap is a puppet method, therefore not available in Ruby and throws an error. Also the value is unwrapped earlier, therefore it is pretty much trying to unwrap the value twice.
Adding an acceptance test to confirm the Sensitive value works.
The following PR is adding the same test as added here, and all acceptance tests are failing which proves this fix is needed.
#492