Add skip_hooks property to vcsrepo #557
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
New property skip_hooks to manage if a repository should not respond to hooks It's tied to a new :hooks_allowed feature
Git provider implements skip_hooks by setting the local config core.hooksPath parameter to /dev/null
Use propper property skip_hooks magic methods, avoid boilerplate Do not use a default property value. It should be unmanaged by default
Add tests for when skip_hooks is manage :either true or :false
Git versions under 1.7.4 did not have the --local flag config specifyier Add support for older versions which by default look for a local .git/config file
|
I believe CI is failing due to provisioning |
petergmurphy
approved these changes
Aug 8, 2022
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add new property
skip_hooksto control wether the repository should actively ignore configured hooks(local, global or system)Implemented for the
gitproviderProblematic
When using
vcsrepoto manage a git repository, having global git hooks configured can mess with the functionality of the module. If checkout hooks are configured they may make any git checkout operation fail.