support per-repo HTTP proxy for the git provider #576
Merged
+141
−26
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Proxies can be specified either as a single proxy or as one or more per-remote proxies. Since the proxy config need not be supported for _every_ git command, define a new wrapper function to be used for git operations that need remote access, and then prepend the proxy arguments in that wrapper. This implementation is better than the previously-documented method of using proxies when: a. Global configuration is not desired. b. Initial `git clone` should/must use a proxy. The previously-documented method is still available for different use cases; reword the original instructions so that they are specified as an alternative rather than the primary method. Move all proxy information into its own section, since this has become rather large to be included in general git usage.
LukasAud
approved these changes
Nov 2, 2022
|
You're welcome, and thank you. |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proxies can be specified either as a single proxy or as one or more per-remote proxies.
Since the proxy config need not be supported for every git command, define a new wrapper function to be used for git operations that need remote access, and then prepend the proxy arguments in that wrapper.
This implementation is better than the previously-documented method of using proxies when:
a. Global configuration is not desired.
b. Initial
git cloneshould/must use a proxy.The previously-documented method is still available for different use cases; reword the original instructions so that they are specified as an alternative rather than the primary method.
Move all proxy information into its own section, since this has become rather large to be included in general git usage.