(GH-585/CONT-998) Fix for safe_directory logic #605
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Due to mistake in the logic unsafe directory was previously removed on every other run. The logic previously checked whether the unsafe directory needed to be added, removing it if this was false without taking into account when it was already set but we wanted it to be left in place.
david22swan
force-pushed
the
GH-585--CONT-998/main/unsafe_directoryfix
branch
from
d3b519a to
dcf9ac6
Compare
|
Can we get some sort of test on this logic please? 😄 |
|
There already is one that should have caught this. Not sure why it didn't |
david22swan
force-pushed
the
GH-585--CONT-998/main/unsafe_directoryfix
branch
4 times, most recently
from
e02932a to
6db82af
Compare
david22swan
force-pushed
the
GH-585--CONT-998/main/unsafe_directoryfix
branch
from
6db82af to
04d5e68
Compare
…stem level Safe directory is now set at a system wide level rather than at a global user level in order to ensure it is as effective as possible.
david22swan
force-pushed
the
GH-585--CONT-998/main/unsafe_directoryfix
branch
from
7da43e5 to
64586c3
Compare
|
Test added/updated |
|
Doing this at system level is a problem when running puppet as non-root, which I am doing in a container. Non-root users can't write to /etc/gitconfig. I will see if I can create that file in the containers /etc folder to be writable. - Update: I had to make /etc/ directory in the container writable by my non-root user, making the gitconfig file writable wasn't enough. |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Due to mistake in the logic unsafe directory was previously removed on every other run. The logic previously checked whether the unsafe directory needed to be added, removing it if this was false without taking into account when it was already set but we wanted it to be left in place.
In addition: safe directory is now set at a system wide level rather than at a global user level in order to ensure it is as effective as possible.