Skip to content

Update to v0.14.0-rc3 #62

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom
Merged
merged 7 commits into from
Dec 10, 2020
Merged

Update to v0.14.0-rc3 #62

merged 7 commits into from
Dec 10, 2020

Conversation

JordanMartinez
Copy link
Contributor

@JordanMartinez
Copy link
Contributor Author

This still won't build because it relies on Spec. It'll take a bit more work to update completely.

@JordanMartinez
Copy link
Contributor Author

This should pass now, but it uses MonadZero's guard. What should that function be replaced with now?

@garyb
Copy link
Member

garyb commented Dec 5, 2020

There's an Alternative-constrained guard now that should work I think?

@JordanMartinez
Copy link
Contributor Author

Yup, that works. I've updated this PR.

@thomashoneyman
Copy link
Contributor

Could we add the dependency changes to the changelog?

@JordanMartinez
Copy link
Contributor Author

How's that? Or did you mean something more than that?

@JordanMartinez
Copy link
Contributor Author

I'm actually not sure that numbers is needed as it's likely pulled in via a transitive dependency

@thomashoneyman thomashoneyman merged commit fca6cdd into purescript-contrib:main Dec 10, 2020
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@thomashoneyman thomashoneyman thomashoneyman approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@JordanMartinez @garyb @thomashoneyman