Implement ap in terms of Bind
#229
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Moves `ap` to Control.Bind and implements it in terms of just Bind rather than Monad * Moves the Applicative Superclass law from Monad to Bind and renames it to the Apply Superclass law Note that this should be non-breaking since `ap` is now re-exported from Control.Monad.
JordanMartinez
approved these changes
Oct 3, 2020
thomashoneyman
approved these changes
Oct 3, 2020
Co-authored-by: Thomas Honeyman <thoneyman@awakesecurity.com>
4 tasks
JordanMartinez
added a commit
that referenced
this pull request
Jan 13, 2021
* Write changelog for upcoming release * Add v4.1.1 release to changelog * Document changes that happened in v4.1.1 release * Add #229 to breaking changes * Remove backticks around 'do notation' * Rephrase 'make library compile on v0.14.0' * Separate documentation improvement PRs from other improvements * Include other PR related to v0.14.0 in changelog * Add toRep PR * Put Array do notation and Monoid newtype PR summary on one line * Include PR that fixes typo * Change section header back to Unreleased
turlando
pushed a commit
to purescm/purescript-prelude
that referenced
this pull request
Sep 3, 2021
* Write changelog for upcoming release * Add v4.1.1 release to changelog * Document changes that happened in v4.1.1 release * Add purescript#229 to breaking changes * Remove backticks around 'do notation' * Rephrase 'make library compile on v0.14.0' * Separate documentation improvement PRs from other improvements * Include other PR related to v0.14.0 in changelog * Add toRep PR * Put Array do notation and Monoid newtype PR summary on one line * Include PR that fixes typo * Change section header back to Unreleased
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
apto Control.Bind and implements it in terms of just Bindrather than Monad
to the Apply Superclass law
Note that this should be non-breaking since
apis now re-exported fromControl.Monad.
Fixes #158