Ports purescript-proxy into this repo
#230
Conversation
|
I'll have to get to this later:
|
src/Data/Symbol.purs
Outdated
|
|
||
| -- local definition for use in `reifySymbol` | ||
| foreign import unsafeCoerce :: forall a b. a -> b | ||
|
|
||
| reifySymbol :: forall r. String -> (forall sym. IsSymbol sym => SProxy sym -> r) -> r | ||
| reifySymbol s f = coerce f { reflectSymbol: \_ -> s } SProxy where | ||
| reifySymbol :: forall r. String -> (forall sym. IsSymbol sym => Proxy sym -> r) -> r |
There was a problem hiding this comment.
I think this should use a type variable proxy instead of Proxy, for the same reason as reflectProxy - that is, so that it works with both Proxy and SProxy until we update it again later.
There was a problem hiding this comment.
Good catch! I've fixed that in latest commits.
|
Should the docs for |
|
I don't think that's necessary; it will be clear that Proxy can be used for any kind once someone has come across the idea of polymorphic kinds, and I think the documentation for polykinds would be a better place to introduce things like the fact that you can use Proxy with any kind. |
|
Ok. Then I think this PR is ready to be merged if there are no other changes I need to make. |
Since
SProxyis defined in Prelude, we need to portpurescript-proxy'sProxytype to here instead now that it can be polykinded.Note: I assume that
IsSymbolshould useProxynow rather thanSProxy.