Skip to content

Change NoConstructors to a newtype over Void #249

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Closed
wants to merge 1 commit into from
Closed

Change NoConstructors to a newtype over Void #249

wants to merge 1 commit into from

Conversation

JordanMartinez
Copy link
Contributor

Fixes #247

@kl0tl
Copy link
Member

kl0tl commented Dec 26, 2020

I don’t think we should do this: I doubt being able to eliminate terms of type NoConstructors with absurd is useful enough when we can already use unsafeCrashWith "unreachable" or unsafeCoerce.

@hdgarrood
Copy link
Contributor

I do think that setting things up so that you don’t need to use unsafe functions is generally worth it, but since this doesn’t appear to be a breaking change we can deal with it after 0.14.0.

@kl0tl
Copy link
Member

kl0tl commented Dec 26, 2020

I agree, but here I'd prefer to not commit to this encoding yet so we can try to make some progress on purescript/purescript#2922.

@JordanMartinez
Copy link
Contributor Author

Ok. I'll close this then. Thanks for the feedback.

@JordanMartinez JordanMartinez deleted the updateNoConstructors branch September 24, 2021 14:37
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[generics-rep] newtype NoConstructors = NoConstructors Void
3 participants