Complete daniel-chambers' PR adding Show instances to generics rep types #250
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Helps one see the generic representation for a given value
kl0tl
reviewed
Dec 26, 2020
test/Data/Generic/Rep.purs
Outdated
Comment on lines
126
to
128
| assert "Checking show for generic types" $ | ||
| show (G.from $ cons 1 Nil) == "(Inr (Constructor \"Cons\" (Argument { head: 1, tail: Nil })))" | ||
|
|
There was a problem hiding this comment.
Could we also test the show output for G.from Nil to cover NoArguments and the Inl constructor, as well as a constructor with multiple arguments to cover Product?
hdgarrood
reviewed
Dec 26, 2020
src/Data/Generic/Rep.purs
Outdated
| -- | A representation for constructors which includes the data constructor name | ||
| -- | as a type-level string. | ||
| newtype Constructor (name :: Symbol) a = Constructor a | ||
|
|
||
| instance showConstructor :: (IsSymbol name, Show a) => Show (Constructor name a) where | ||
| show (Constructor a) = "(Constructor " <> show (reflectSymbol (Proxy :: Proxy name)) <> " " <> show a <> ")" |
There was a problem hiding this comment.
Can I request that we put a @ symbol before the constructor name? It wouldn’t be valid syntax (we don’t have explicit type applications) but it does at least clarify that the string isn’t an actual constructor argument for Constructor.
There was a problem hiding this comment.
Meaning this? Yeah, I think that makes sense.
- "(Constructor " <> show (reflectSymbol ...
+ "(Constructor @" <> show (reflectSymbol ...
hdgarrood
approved these changes
Dec 26, 2020
turlando
pushed a commit
to purescm/purescript-prelude
that referenced
this pull request
Sep 3, 2021
…pes (purescript#250) * Add Show instance to generic rep types (complete daniel-chambers PR) Helps one see the generic representation for a given value * Add `@` in front of constructor name in Show instance for generic type * Add tests for Inl, NoArguments, and Product
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Completes the PR he started in purescript-deprecated/purescript-generics-rep#11