Skip to content

Remove deprecated 'unsafeCompare' #257

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom
Merged
merged 2 commits into from
Jan 13, 2021
Merged

Remove deprecated 'unsafeCompare' #257

merged 2 commits into from
Jan 13, 2021

Conversation

JordanMartinez
Copy link
Contributor

@JordanMartinez JordanMartinez commented Jan 13, 2021 •
edited
Loading

Fixes #256

  • Added change to changelog

@JordanMartinez
Copy link
Contributor Author

We should probably merge this after #256 so I can add this to the changelog.

hdgarrood
hdgarrood approved these changes Jan 13, 2021
View reviewed changes
Copy link
Contributor

@hdgarrood hdgarrood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have no preference for merging before or after the changelog PR but just wanted to give the approval so that you can merge when you’re ready.

@JordanMartinez JordanMartinez merged commit 898f35a into purescript:master Jan 13, 2021
@JordanMartinez JordanMartinez deleted the removeUnsafeCompare branch January 13, 2021 20:41
turlando pushed a commit to purescm/purescript-prelude that referenced this pull request Sep 3, 2021
@JordanMartinez @turlando
Remove deprecated 'unsafeCompare' (purescript#257)
ee49b8f 
* Remove deprecated unsafeCompare

* Update changelog to include this PR
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@hdgarrood hdgarrood hdgarrood approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Remove deprecated unsafeCompare
2 participants
@JordanMartinez @hdgarrood