Clean Unit test up (favor ExpectedException over try catch fail) #17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
||
| public class PrivateConstructionCheckerTest { | ||
| @Rule public ExpectedException expectedException = ExpectedException.none(); |
|
LGTM @artem-zinnatullin PTAL, please |
| expectedException.expectMessage("expectedTypeOfException can not be null"); | ||
| PrivateConstructorChecker | ||
| .forClass(Object.class) | ||
| .expectedTypeOfException(null); |
There was a problem hiding this comment.
Can you please divide forClass and expectedTypeOfException, I mean, to make sure that it fails after call to the expectedTypeOfException and not to the forClass
|
Sorry for tons of same comments, but they'll help during next iteration of code review |
Reordered ExpectedException to be closer to the origin
|
@artem-zinnatullin don't worry. You're right. I hope I got every place. |
|
👍 |
artem-zinnatullin
added a commit
that referenced
this pull request
Dec 16, 2015
Clean Unit test up (favor ExpectedException over try catch fail)
|
@vanniktech thanks! |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.