Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

[WIP] Implement the Plataforma Solar de Almerı́a (PSA) solar position algorithm #2152

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

kandersolar
Copy link
Member

The PSA algorithm seems to be as accurate as pvlib's ephemeris method but 3-4 times faster. Here is a brief comparison:

image

@AdamRJensen
Copy link
Member

Are you implementing the 2001 version or the 2020 version?

@kandersolar
Copy link
Member Author

The equations are the same between the two versions; only the coefficients differ. The current function lets the user choose which set of coefficients to use, with 2020 coefficients being the default.

@AdamRJensen
Copy link
Member

In the equations in the 2020 paper, it seems that the right ascension ra variable isn't used in any calculations - am I missing something?

@AdamRJensen
Copy link
Member

Given that the PSA and Michalsky algorithms are almost the same, maybe we should consider only adding Michalsky?

@adriesse
Copy link
Member

almost the same

Could you elaborate on the similarities/differences?

I think the main usage of these algorithms will be to verify or replicate published output from other people or software, so even small differences could be relevant.

# for free to join this conversation on GitHub. Already have an account? # to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants