Fix a bunch of bugs #25
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1. Fix bug where "+ cd ..." is printed multiple times. Instead check what the last "cd" was set to, and if this one is the same, don't "cd" again. 2. Fix bug where backend config was getting appended to the init command every time the _final_vars function was called
Need to have both 'cd' operations follow each other. Also make revgrep run in a subshell so 'cd' in that command doesn't negatively effect other commands
If apply errors, the return status was being returned 0. Instead return the actual return status.
Fixes a bug where 'mktemp -p' does not work on MacOS and the 'terraformsh state rm ...' command results in no backup file getting created.
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix number of bugs that i've been negligent in pushing...
The biggest one is that 'terraform apply' failures would return 0 no matter what.
The second biggest one is that
mktempon MacOS does not support the-poption, leading to not creating a backup file when runningterraform state rm ...commands.