Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Add markdownify #36

Closed
victorbnl opened this issue Sep 4, 2021 · 5 comments
Closed

Add markdownify #36

victorbnl opened this issue Sep 4, 2021 · 5 comments

Comments

@victorbnl
Copy link

It would be great to add the markdownify filter

@pwwang
Copy link
Owner

pwwang commented Sep 4, 2021

Could you attach a reference link?

@victorbnl
Copy link
Author

Oh, I though you already knew it, as there is a comment like TODO: markdownify, ... in your code (if I remember well). Anyway, the documentation is really concise about it, so I can't tell you a lot of things, apart from the fact it's a Jekyll filter that transforms its input from markdown into html.

Here is the source code of the filter in Jekyll if it can help you: https://github.com/jekyll/jekyll/blob/9957e21be7f45e791725a9e0a963b329f79c2615/lib/jekyll/filters.rb#L16

@victorbnl
Copy link
Author

I just saw your code and it doesn't seem complicated, so I'll make a PR

@victorbnl
Copy link
Author

Should I include it in the standard mode?

@pwwang
Copy link
Owner

pwwang commented Sep 4, 2021

Ah, then I think it's better to add it to the jekyll mode to avoid confusion. PRs are very welcome, just remember to push to the dev branch.

@pwwang pwwang mentioned this issue Oct 13, 2021
@pwwang pwwang closed this as completed Oct 13, 2021
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants