Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Add markdownify #37

Closed
wants to merge 1 commit into from
Closed

Add markdownify #37

wants to merge 1 commit into from

Conversation

victorbnl
Copy link

@victorbnl victorbnl commented Sep 4, 2021 •
edited
Loading

Fix #36

@pwwang
Copy link
Owner

pwwang commented Sep 4, 2021

Just a few things: Could you

  1. push it to dev branch?
  2. make markdown dependency optional?
  3. add some tests for it? At tests/jekyll/test_filters.py?

Thanks.

@victorbnl victorbnl changed the base branch from master to dev September 4, 2021 17:11
@pwwang
Copy link
Owner

pwwang commented Oct 13, 2021

Will be added in the next version.

@pwwang pwwang closed this Oct 13, 2021
@pwwang pwwang mentioned this pull request Oct 13, 2021
Merged
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add markdownify
2 participants
@victorbnl @pwwang