-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Move from poetry
and just
to pixi
#595
Conversation
Cool! I'll take a look tomorrow 🚀 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just some questions
pyproject.toml
Outdated
version = "0.24.1" | ||
dependencies = ["lets-plot>=4.0.1"] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Don't we need the runtime dependencies here? See https://github.com/ericmjl/llamabot/blob/main/pyproject.toml (from the author of https://ericmjl.github.io/blog/2024/8/16/its-time-to-try-out-pixi/). I am not 100% sure about it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lets-plot
cannot be installed from conda
, so I added it via pixi add lets_plot --pypi
, which placed it there in the toml. I think (but am not sure) that this is where pixi
places all non-conda deps?
Could it be the poetry dependency in https://github.com/py-econometrics/wildboottest/blob/fd72d390f441c9093b9fbb587edb747c17e97953/pyproject.toml#L24-L32 ? |
@juanitorduz, I think this is ready now, minus the pixi add --pypi --feature dev wildboottest==0.3.1 leads to a memory error |
weird 🤔 Does it also happen with a fresh env with Poetry? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! Just left some small comments and suggestions
@s3alfisc I can not install it in my Mac > pixi shell
× The current platform does not satisfy the minimal virtual package requirements
╰─▶ the project does not support 'osx-arm64' I think we need to add both mac platforms as in https://github.com/ericmjl/llamabot/blob/main/pyproject.toml#L118 we currently have platforms = ["linux-64", "win-64"] We need platforms = ["osx-arm64", "linux-64", "osx-64", "win-64"] |
Thanks @juanitorduz, just added mac support in the last commit |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I tested locally and it the installation works! I also ran pixi run lint
and pixi run test
and both work as expected!
Perfect, thank you! |
My fingers itched a bit so I played around with
pixi
=)This PR is really just a "proof of concept". It does two things:
pyfixest
from usingpoetry
to usingpixi
for package management.just
file topixi
tasks.For me, the environment currently works "as is", but:
conda
, which means we will not be able to host on PyPi. We need to explicitly tellpixi
to install from PyPiwildboottest
because of a version conflict (?, not sure where this stems from), so the tests fail.pixi run tests-regular
and all dev dependencies will be installed in a "test" env + the unit tests will run.