Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Add RUFF rules #697

Merged
merged 1 commit into from
Nov 6, 2024
Merged

Conversation

juanitorduz
Copy link
Contributor

@juanitorduz juanitorduz commented Nov 5, 2024

This is another PR (and probably the final in this sequence) to improve the code base through the linter. I suggest using the RUFF set of rules https://docs.astral.sh/ruff/rules/#ruff-specific-rules-ruf, which sounds very reasonable.

Copy link

codecov bot commented Nov 5, 2024

Codecov Report

Attention: Patch coverage is 87.50000% with 1 line in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
pyfixest/report/summarize.py 50.00% 1 Missing ⚠️
Flag Coverage Δ
core-tests 77.80% <87.50%> (+0.11%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
pyfixest/did/did2s.py 90.56% <ø> (+0.56%) ⬆️
pyfixest/estimation/FixestMulti_.py 80.20% <ø> (ø)
pyfixest/estimation/FormulaParser.py 96.48% <100.00%> (-0.02%) ⬇️
pyfixest/estimation/feols_.py 83.24% <100.00%> (+0.25%) ⬆️
pyfixest/estimation/feols_compressed_.py 83.43% <100.00%> (ø)
pyfixest/estimation/fepois_.py 87.20% <ø> (ø)
pyfixest/report/summarize.py 87.00% <50.00%> (+0.21%) ⬆️

@s3alfisc
Copy link
Member

s3alfisc commented Nov 6, 2024

Looks good, thank you @juanitorduz!

@s3alfisc s3alfisc merged commit f1c8a59 into py-econometrics:master Nov 6, 2024
8 checks passed
@juanitorduz juanitorduz deleted the add-ruff-rules branch November 6, 2024 18:22
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants