Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

fix docstring typos #721

Merged
merged 1 commit into from
Nov 18, 2024
Merged

fix docstring typos #721

merged 1 commit into from
Nov 18, 2024

Conversation

RoyalTS
Copy link
Contributor

@RoyalTS RoyalTS commented Nov 18, 2024

Changes so minor I almost want to apologize. Stumbled on whilst going through code, seemed worth fixing, even just for aesthetic/OCD reasons :)

@s3alfisc
Copy link
Member

Ah but that's great! Thank you @RoyalTS. This part of the code base is the most "hacky", please let me know in case you have any thoughts on how to improve it =)

@s3alfisc
Copy link
Member

@all-contributors please add @RoyalTS for docs

Copy link
Contributor

@s3alfisc

I've put up a pull request to add @RoyalTS! 🎉

@s3alfisc s3alfisc merged commit 37bedd8 into py-econometrics:master Nov 18, 2024
1 check passed
@RoyalTS
Copy link
Contributor Author

RoyalTS commented Nov 21, 2024

Feels way out of proportion to name me as a contributor for changing three characters. If this is a subtle attempt to try to guilt me into making an actual contribution, it may be working :)

@RoyalTS RoyalTS deleted the patch-1 branch November 21, 2024 09:22
@s3alfisc
Copy link
Member

Haha I feel seen 😄 though beyond this being a not so subtle attempt to incentivize / lure one-off contributors to contribute more regularly, I really like the idea to also acknowledge contributions that go beyond writing code & implementing full features. And then it's somewhat difficult to make a cutoff, so my decision rule at the moment is that "everything that is merged or leads to a code change" qualifies =)

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants