Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

fix bug in ritest with randomization-t #730

Merged
merged 3 commits into from
Dec 3, 2024
Merged

fix bug in ritest with randomization-t #730

merged 3 commits into from
Dec 3, 2024

Conversation

s3alfisc
Copy link
Member

@s3alfisc s3alfisc commented Dec 3, 2024

Fixes #717. See the issue for details.

@s3alfisc s3alfisc merged commit 10a8fb8 into master Dec 3, 2024
8 checks passed
@s3alfisc s3alfisc deleted the ritest-t-bug branch December 3, 2024 21:52
Copy link

codecov bot commented Dec 3, 2024

Codecov Report

Attention: Patch coverage is 75.00000% with 2 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
pyfixest/estimation/feols_.py 75.00% 2 Missing ⚠️
Flag Coverage Δ
core-tests 78.33% <75.00%> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
pyfixest/estimation/multcomp.py 78.48% <ø> (ø)
pyfixest/estimation/feols_.py 83.62% <75.00%> (-0.14%) ⬇️

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Randomization inference, "ri" sampling_method in rwolf, gives too tight a sample of null t-statistics
1 participant