Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

DEV: Add REL to known PR prefixes #2554

Merged
merged 1 commit into from
Mar 29, 2024
Merged

DEV: Add REL to known PR prefixes #2554

merged 1 commit into from
Mar 29, 2024

Conversation

stefan6419846
Copy link
Collaborator

Fixes #2499.

@stefan6419846 stefan6419846 added the nf-ci Non-functional change: Continuous Integration label Mar 29, 2024
@stefan6419846 stefan6419846 mentioned this pull request Mar 29, 2024
Closed
@codecov Codecov
Copy link

codecov bot commented Mar 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.67%. Comparing base (719ff25) to head (f1f0331).

Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #2554   +/-   ##
=======================================
  Coverage   94.67%   94.67%           
=======================================
  Files          50       50           
  Lines        8231     8231           
  Branches     1646     1646           
=======================================
  Hits         7793     7793           
  Misses        268      268           
  Partials      170      170

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

MartinThoma
MartinThoma approved these changes Mar 29, 2024
View reviewed changes
Copy link
Member

@MartinThoma MartinThoma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I thought it would not be necessary to add REL as get_git_commits_since_tag should never return a REL commit. But it certainly does not harm and I see the value for robustness / documentation 👍

@stefan6419846
Copy link
Collaborator Author

You mixed up something - this is the script for the PR title check.

See https://github.com/py-pdf/pypdf/actions/runs/8129716860/job/22217137167 - our PR title check would fail for the last release PR.

@MartinThoma
Copy link
Member

Oh, thanks for pointing it out 👍 😅

@MartinThoma
Copy link
Member

Still I keep the "approve" - feel free to merge :-)

@stefan6419846 stefan6419846 merged commit 68b0465 into py-pdf:main Mar 29, 2024
16 checks passed
@stefan6419846 stefan6419846 deleted the rel_prefix branch March 29, 2024 14:11
stefan6419846 added a commit that referenced this pull request Apr 7, 2024
@stefan6419846
REL: 4.2.0
2ac88e6 
REL: 4.2.0

## What's new

### New Features (ENH)
- Allow multiple charsets for NameObject.read_from_stream (#2585) by @pubpub-zz
- Add support for /Kids in page labels (#2562) by @stefan6419846
- Allow to update fields on many pages (#2571) by @pubpub-zz
- Tolerate PDF with invalid xref pointed objects (#2335) by @pubpub-zz
- Add Enforce from PDF2.0 in viewer_preferences (#2511) by @pubpub-zz
- Add += and -= operators to ArrayObject (#2510) by @pubpub-zz

### Bug Fixes (BUG)
- Fix merge_page sometimes generating unknown operator 'QQ' (#2588) by @rfotino
- Fix fields update where annotations are kids of field (#2570) by @pubpub-zz
- Process CMYK images without a filter correctly (#2557) by @pubpub-zz
- Extract text in layout mode without finding resources (#2555) by @pubpub-zz
- Prevent recursive loop in some PDF files (#2505) by @pubpub-zz

### Robustness (ROB)
- Tolerate "truncated" xref (#2580) by @pubpub-zz
- Replace error by warning for EOD in RunLengthDecode/ASCIIHexDecode (#2334) by @pubpub-zz
- Rebuild xref table if one entry is invalid (#2528) by @pubpub-zz
- Robustify stream extraction (#2526) by @pubpub-zz

### Documentation (DOC)
- Update release process for latest changes (#2564) by @stefan6419846
- Encryption/decryption: Clone document instead of copying all pages (#2546) by @redfast00
- Minor improvements (#2542) by @j-t-1
- Update annotation list (#2534) by @j-t-1
- Update references and formatting (#2529) by @j-t-1
- Correct threads reference, plus minor changes (#2521) by @j-t-1
- Minor readability increases (#2515) by @j-t-1
- Simplify PaperSize examples (#2504) by @j-t-1
- Minor improvements (#2501) by @j-t-1

### Developer Experience (DEV)
- Remove unused dependencies (#2572) by @stefan6419846
- Remove page labels PR link from message (#2561) by @stefan6419846
- Fix changelog generator regarding whitespace and handling of "Other" group (#2492) by @stefan6419846
- Add REL to known PR prefixes (#2554) by @stefan6419846
- Release using the REL commit instead of git tag (#2500) by @MartinThoma
- Unify code between PdfReader and PdfWriter (#2497) by @pubpub-zz
- Bump softprops/action-gh-release from 1 to 2 (#2514) by @dependabot[bot]

### Maintenance (MAINT)
- Ressources → Resources (and internal name childs) (#2550) by @pubpub-zz
- Fix typos found by codespell (#2549) by @stefan6419846
- Update Read the Docs configuration (#2538) by @j-t-1
- Add root_object, _info and _ID to PdfReader (#2495) by @pubpub-zz

### Testing (TST)
- Allow loading truncated images if required (#2586) by @stefan6419846
- Fix download issues from #2562 (#2578) by @pubpub-zz
- Improve test_get_contents_from_nullobject to show real use-case (#2524) by @stefan6419846
- Add missing test annotations (#2507) by @stefan6419846

[Full Changelog](4.1.0...4.2.0)
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@MartinThoma MartinThoma MartinThoma approved these changes

Assignees
No one assigned
Labels
nf-ci Non-functional change: Continuous Integration
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Review release process docs for PR-based releases
2 participants
@stefan6419846 @MartinThoma