Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

BUG: fix sheared image #2801

Merged
merged 3 commits into from
Aug 15, 2024
Merged

BUG: fix sheared image #2801

merged 3 commits into from
Aug 15, 2024

Conversation

pubpub-zz
Copy link
Collaborator

closes #2411

Copy link

codecov bot commented Aug 14, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.86%. Comparing base (d9a8c54) to head (72e9f54).
Report is 71 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2801   +/-   ##
=======================================
  Coverage   95.86%   95.86%           
=======================================
  Files          51       51           
  Lines        8528     8528           
  Branches     1691     1691           
=======================================
  Hits         8175     8175           
  Misses        209      209           
  Partials      144      144           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@stefan6419846
Copy link
Collaborator

Is there an easy way to craft a test for this without using the original restricted file?

@stefan6419846
Copy link
Collaborator

https://corpora.tika.apache.org/base/docs/govdocs1/938/938702.pdf-tika-938702.pdf apparently has been deleted and cannot be used directly anymore.

@stefan6419846
Copy link
Collaborator

Nearly minimal test file for this issue (thanks to @pubpub-zz for providing support with minimizing the embedded image): tt.pdf

@pubpub-zz
Copy link
Collaborator Author

image:
tt

@pubpub-zz
Copy link
Collaborator Author

https://corpora.tika.apache.org/base/docs/govdocs1/938/938702.pdf-tika-938702.pdf apparently has been deleted and cannot be used directly anymore.

in replacement:
tika-938702.pdf

@stefan6419846 stefan6419846 merged commit 799630d into py-pdf:main Aug 15, 2024
16 checks passed
@pubpub-zz pubpub-zz mentioned this pull request Sep 15, 2024
pubpub-zz added a commit that referenced this pull request Sep 17, 2024
## Version 5.0.0, 2024-09-15

This version drops support for Python 3.7 (not maintained since July 2023), PdfMerger (use PdfWriter instead) and AnnotationBuilder (use annotations instead).


### Deprecations (DEP)
- Remove the deprecated PfdMerger and AnnotationBuilder classes and other deprecations cleanup (#2813)
- Drop Python 3.7 support (#2793)

### New Features (ENH)
- Add capability to remove /Info from PDF (#2820)
- Add incremental capability to PdfWriter (#2811)
- Add UniGB-UTF16 encodings (#2819)
- Accept utf strings for metadata (#2802)
- Report PdfReadError instead of RecursionError (#2800)
- Compress PDF files merging identical objects (#2795)

### Bug Fixes (BUG)
- Fix sheared image (#2801)

### Robustness (ROB)
- Robustify .set_data() (#2821)
- Raise PdfReadError when missing /Root in trailer (#2808)
- Fix extract_text() issues on damaged PDFs (#2760)
- Handle images with empty data when processing an image from bytes (#2786)

### Developer Experience (DEV)
- Fix coverage uploads (#2832)
- Test against Python 3.13 (#2776)


[Full Changelog](4.3.1...5.0.0)
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Extracted image is being distorted
2 participants