STY: Remove variable check_crlf_space

[j-t-1]

No description provided.

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.60%. Comparing base (3c72462) to head (514982d).

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #3096      +/-   ##
==========================================
- Coverage   96.60%   96.60%   -0.01%     
==========================================
  Files          53       53              
  Lines        8979     8974       -5     
  Branches     1659     1659              
==========================================
- Hits         8674     8669       -5     
  Misses        183      183              
  Partials      122      122              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[stefan6419846]

Doesn't this decrease readability/overview?

[j-t-1]

Whether to check_crlf_space depends on if operator in ( b"Td", b"Tm", b"T*", b"Tj"). So the variable is recording something we already know and thus decreases readability.

[stefan6419846]

There is a superfluous whitespace here. Additionally: Will operator always be a primitive type which would allow converting the right-hand side to a set for faster lookups?

[j-t-1]

Apart from this line they are always bytes literals:

pypdf/pypdf/_page.py

Line 2143 in 3c72462

process_operation(operator, operands)

operator comes from content.operations:

pypdf/pypdf/_page.py

Line 2068 in 3c72462

for operands, operator in content.operations:

content comes from:

pypdf/pypdf/_page.py

Lines 1863 to 1867 in 3c72462

	content = (
	obj[content_key].get_object() if isinstance(content_key, str) else obj
	)
	if not isinstance(content, ContentStream):
	content = ContentStream(content, pdf, "bytes")

operator is stored as bytes in ContentStream:

pypdf/pypdf/generic/_data_structures.py

Line 1166 in 3c72462

self._operations: List[Tuple[Any, bytes]] = []

So operator will always be a primitive type (bytes).