Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The pre-built SDL2 binaries for macOS on the official website are all packaged in .framework format. However, PySDL2 currently only looks for SDL2 DLLs in .dylib format, meaning that if you download the official frameworks and try to point
PYSDL2_DLL_PATH
towards them, it won't be able to find them.This patch fixes this, and lays the groundwork for having a separate 'pysdl2-dlls wheel' that contains the official pre-built SDL2 + extras runtime libraries which would solve #78 (I currently have a script/package to create such a wheel for macOS and it seems to work well using this fix!)