Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Add 2d response array support to DRLearner #209

Merged
merged 2 commits into from
Jan 13, 2020
Merged

Conversation

kbattocchi
Copy link
Collaborator

As requested by the DoWhy team, this adds support for 2D arrays for the response when using DRLearner (though still limited to a single response).

@kbattocchi kbattocchi requested a review from vasilismsr January 6, 2020 19:22
@kbattocchi kbattocchi force-pushed the kebatt/drlearnerArrays branch from 2a4d6db to 56b6c0a Compare January 10, 2020 21:19
econml/drlearner.py Show resolved Hide resolved
@kbattocchi kbattocchi force-pushed the kebatt/drlearnerArrays branch from 56b6c0a to 53c85d8 Compare January 13, 2020 19:44
@kbattocchi kbattocchi requested a review from vasilismsr January 13, 2020 20:11
Copy link
Contributor

@vasilismsr vasilismsr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kbattocchi kbattocchi merged commit 2b5420f into master Jan 13, 2020
@kbattocchi kbattocchi deleted the kebatt/drlearnerArrays branch January 13, 2020 20:18
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants