Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Fix RScorer circular import #596

Merged
merged 6 commits into from
Apr 7, 2022
Merged

Conversation

fverac
Copy link
Collaborator

@fverac fverac commented Apr 1, 2022

No description provided.

@fverac fverac force-pushed the fverac/fixRScorerCircularImport branch from 8353649 to ca6088e Compare April 1, 2022 14:12
@fverac fverac requested a review from kbattocchi April 1, 2022 14:13
@kbattocchi
Copy link
Collaborator

If possible, add a test that would have failed prior to the fix.

Fix RScorer circular import

Fix RScorer circular import
@fverac fverac force-pushed the fverac/fixRScorerCircularImport branch from 05ec7c2 to 70c3aaf Compare April 1, 2022 14:52
@fverac fverac linked an issue Apr 1, 2022 that may be closed by this pull request
Copy link
Collaborator

@kbattocchi kbattocchi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@kbattocchi kbattocchi marked this pull request as ready for review April 7, 2022 20:36
@kbattocchi kbattocchi merged commit 5bb484c into main Apr 7, 2022
@kbattocchi kbattocchi deleted the fverac/fixRScorerCircularImport branch April 7, 2022 20:36
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ImportError - Circular Import RScorer
2 participants