Fix AUROC to work with torchmetrics >=0.11 (bump required version to 0.11) #1181
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportBase: 29.98% // Head: 30.09% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## develop #1181 +/- ##
===========================================
+ Coverage 29.98% 30.09% +0.10%
===========================================
Files 61 61
Lines 3788 3798 +10
===========================================
+ Hits 1136 1143 +7
- Misses 2652 2655 +3
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
hbredin
requested changes
Dec 8, 2022
use compute_on_cpu on AUROC metrics
FrenchKrab
changed the title
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With torchmetrics 0.11, AUROC implemention has made a breaking change and now requires to specify the problem type (multiclass/multilabel/binary classification).
(see v0.10 API vs v0.11 API)
This pull request fixes obsolete ("deprecated" in v0.10.x but still worked) AUROC uses and (should) allow unit tests to pass again.
It also bumps the required torchmetrics version to 0.10 because these new specialized AUROC didn't seem to exist before.
(It's possible I didn't use the right types of AUROC metrics)