Updated SEI on cracks example #4122
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 4 commits
March 18, 2024 14:55
DrSOKane
requested review from
kratman,
arjxn-py,
agriyakhetarpal and
Saransh-cpp
as code owners
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
|
@DrSOKane In the updated notebook, all the lines in the plots sit on top of each other. Is this intended? |
|
|
|
This is correct. The voltage curves are the same, but the loss of lithium is greater with cracking enabled. |
|
Ok I just wanted to make sure since the change was changing the plotting styles, but then the plots also changed |
What happened was the code got changed, but the plots never updated. So now I've re-run the code to get the plots right. |
kratman
approved these changes
May 31, 2024
js1tr3
pushed a commit
to js1tr3/PyBaMM
that referenced
this pull request
Aug 12, 2024
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Updated plots in SEI on cracks example notebook to improve visibility