Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Performance-notebooks #4787

Merged
merged 27 commits into from
Mar 20, 2025
Merged

Performance-notebooks #4787

merged 27 commits into from
Mar 20, 2025

Conversation

martinjrobins
Copy link
Contributor

@martinjrobins martinjrobins commented Jan 21, 2025

Description

Fixes #4772

Adds a sequence of notebooks focusing on understanding the pybamm pipeline and the performance characteristics of the solvers.

Type of change

Please add a line in the relevant section of CHANGELOG.md to document the change (include PR #) - note reverse order of PR #s. If necessary, also add to the list of breaking changes.

  • New feature (non-breaking change which adds functionality)
  • Optimization (back-end change that speeds up the code)
  • Bug fix (non-breaking change which fixes an issue)

Key checklist:

  • No style issues: $ pre-commit run (or $ nox -s pre-commit) (see CONTRIBUTING.md for how to set this up to run automatically when committing locally, in just two lines of code)
  • All tests pass: $ python -m pytest (or $ nox -s tests)
  • The documentation builds: $ python -m pytest --doctest-plus src (or $ nox -s doctests)

You can run integration tests, unit tests, and doctests together at once, using $ nox -s quick.

Further checks:

  • Code is commented, particularly in hard-to-understand areas
  • Tests added that prove fix is effective or that feature works

Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

Copy link

codecov bot commented Jan 21, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.71%. Comparing base (10a404e) to head (b6f79d4).
Report is 1 commits behind head on develop.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #4787   +/-   ##
========================================
  Coverage    98.71%   98.71%           
========================================
  Files          304      304           
  Lines        23478    23478           
========================================
  Hits         23176    23176           
  Misses         302      302           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@martinjrobins martinjrobins marked this pull request as ready for review February 20, 2025 14:37
@martinjrobins martinjrobins requested a review from a team as a code owner February 20, 2025 14:37
@rtimms
Copy link
Contributor

rtimms commented Feb 23, 2025

@MarcBerliner can you check if the changes you made for the training workshop need making here too, or if they are fixed already? thanks!

brosaplanella
brosaplanella previously approved these changes Mar 17, 2025
Copy link
Member

@brosaplanella brosaplanella left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just some small comments, but looks good to me otherwise. Thanks Martin!

martinjrobins and others added 5 commits March 19, 2025 19:21
…ints.ipynb

Co-authored-by: Ferran Brosa Planella <Ferran.Brosa-Planella@warwick.ac.uk>
…ints.ipynb

Co-authored-by: Ferran Brosa Planella <Ferran.Brosa-Planella@warwick.ac.uk>
…pynb

Co-authored-by: Ferran Brosa Planella <Ferran.Brosa-Planella@warwick.ac.uk>
@martinjrobins martinjrobins merged commit 67e9968 into develop Mar 20, 2025
25 checks passed
@martinjrobins martinjrobins deleted the performance-notebooks branch March 20, 2025 09:57
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

docs: pybamm performance user guide
3 participants