-
-
Notifications
You must be signed in to change notification settings - Fork 606
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Performance-notebooks #4787
Performance-notebooks #4787
Conversation
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #4787 +/- ##
========================================
Coverage 98.71% 98.71%
========================================
Files 304 304
Lines 23478 23478
========================================
Hits 23176 23176
Misses 302 302 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
… into performance-notebooks
@MarcBerliner can you check if the changes you made for the training workshop need making here too, or if they are fixed already? thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just some small comments, but looks good to me otherwise. Thanks Martin!
docs/source/examples/notebooks/performance/01-simulation-pipeline.ipynb
Outdated
Show resolved
Hide resolved
docs/source/examples/notebooks/performance/02-input-parameters.ipynb
Outdated
Show resolved
Hide resolved
docs/source/examples/notebooks/performance/04-interpolation-points.ipynb
Outdated
Show resolved
Hide resolved
docs/source/examples/notebooks/performance/04-interpolation-points.ipynb
Outdated
Show resolved
Hide resolved
docs/source/examples/notebooks/performance/03-pybamm-solvers.ipynb
Outdated
Show resolved
Hide resolved
docs/source/examples/notebooks/performance/06-output-variables.ipynb
Outdated
Show resolved
Hide resolved
…ints.ipynb Co-authored-by: Ferran Brosa Planella <Ferran.Brosa-Planella@warwick.ac.uk>
…ints.ipynb Co-authored-by: Ferran Brosa Planella <Ferran.Brosa-Planella@warwick.ac.uk>
…pynb Co-authored-by: Ferran Brosa Planella <Ferran.Brosa-Planella@warwick.ac.uk>
Description
Fixes #4772
Adds a sequence of notebooks focusing on understanding the pybamm pipeline and the performance characteristics of the solvers.
Type of change
Please add a line in the relevant section of CHANGELOG.md to document the change (include PR #) - note reverse order of PR #s. If necessary, also add to the list of breaking changes.
Key checklist:
$ pre-commit run
(or$ nox -s pre-commit
) (see CONTRIBUTING.md for how to set this up to run automatically when committing locally, in just two lines of code)$ python -m pytest
(or$ nox -s tests
)$ python -m pytest --doctest-plus src
(or$ nox -s doctests
)You can run integration tests, unit tests, and doctests together at once, using
$ nox -s quick
.Further checks: