Minor updates to degradation example #4813
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DrSOKane
requested review from
kratman,
arjxn-py,
agriyakhetarpal and
Saransh-cpp
as code owners
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #4813 +/- ##
========================================
Coverage 98.70% 98.70%
========================================
Files 303 303
Lines 23312 23312
========================================
Hits 23009 23009
Misses 303 303 ☔ View full report in Codecov by Sentry. |
|
I would recommend switching to the |
…degradation-example
Done :) |
kratman
approved these changes
Feb 6, 2025
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
People are still setting
"calculate discharge energy"to true based on my example notebook, so I changed it. I also emphasized the 1 minute period for the 1C discharge step (compared to the 5 minute period for other steps) because that has also caused confusion before.If anyone has other ideas for how to improve the notebook while still being true to the paper it's based on, I am happy to hear them.