Fixes non-virtualbox provider #113
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The function is hardcoding the provider name while there's a variable for that. So use it. Signed-off-by: Arnaud Patard <apatard@hupstream.com>
The machine status returned by vagrant may change between providers so add code to deal with the differences. For now, it's coded inside a function but can be replaced with a dict() if more differences are found. Signed-off-by: Arnaud Patard <apatard@hupstream.com>
Current provider is hardcoded inside the test file. We may want to switch easily between test providers (local testing, using something else than GHA, whatever...) so add a new function used to return the current test provider. Changing the test provider is done by setting an environment variable since any code / logic to detect the provider to use will always be broken. Signed-off-by: Arnaud Patard <apatard@hupstream.com>
konstruktoid
approved these changes
Mar 30, 2022
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains a bunch of fixes to make python-vagrant and its testsuite more provider-agnostic.
The main part is the handling of the state, since vagrant output seems to be dependent of the provider
(for instance "poweroff" versus "shutoff").