Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Nexus-Gerd #61

Merged
merged 9 commits into from
Oct 15, 2021
Merged

Nexus-Gerd #61

merged 9 commits into from
Oct 15, 2021

Conversation

gduscher
Copy link
Member

No description provided.

@codecov-commenter
Copy link

codecov-commenter commented Oct 15, 2021

Codecov Report

Merging #61 (bc8c89f) into master (14e559b) will decrease coverage by 2.10%.
The diff coverage is 60.52%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #61      +/-   ##
==========================================
- Coverage   88.58%   86.47%   -2.11%     
==========================================
  Files          13       11       -2     
  Lines        1209     1235      +26     
==========================================
- Hits         1071     1068       -3     
- Misses        138      167      +29     
Flag Coverage Δ
unittests 86.47% <60.52%> (-2.11%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pyNSID/io/hdf_utils.py 58.46% <6.45%> (-7.75%) ⬇️
tests/io/test_hdf_io.py 91.84% <97.29%> (+0.04%) ⬆️
pyNSID/__init__.py 100.00% <100.00%> (ø)
pyNSID/__version__.py 100.00% <100.00%> (ø)
pyNSID/io/__init__.py 100.00% <100.00%> (ø)
pyNSID/io/hdf_io.py 86.36% <100.00%> (ø)
pyNSID/io/nsi_reader.py 82.97% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 14e559b...bc8c89f. Read the comment docs.

updated tests
nested dictionaries not tested yet
deleted processing and viz directory
updated tests
nested dictionaries not tested yet
deleted processing and viz directory
@gduscher gduscher merged commit bf1a7c9 into master Oct 15, 2021
@gduscher gduscher deleted the nexus-Gerd branch October 15, 2021 22:25
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants