Skip to content

validate by iteration #1620

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Draft
wants to merge 6 commits into
base: main
Choose a base branch
from
Draft

validate by iteration #1620

wants to merge 6 commits into from

Conversation

davidhewitt
Copy link
Contributor

Change Summary

Related to pydantic/jiter#184

By making json object lookup less efficient we should move away from it as much as possible and prefer iteration. We've wanted this anyway for a while as it would be necessary for proper jiter integration.

WIP, I want to introduce a "lookup tree" to handle all the aliases and that madness.

Related issue number

N/A

Checklist

  • Unit tests for the changes exist
  • Documentation reflects the changes where applicable
  • Pydantic tests pass with this pydantic-core (except for expected changes)
  • My PR is ready to review, please add a comment including the phrase "please review" to assign reviewers

Copy link

codspeed-hq bot commented Feb 4, 2025

CodSpeed Performance Report

Merging #1620 will improve performances by 19.34%

Comparing dh/lookup-tree (306c934) with main (741961c)

Summary

⚡ 1 improvements
✅ 156 untouched benchmarks

Benchmarks breakdown

Benchmark BASE HEAD Change
test_core_json_fs 134.7 µs 112.9 µs +19.34%

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant