[wip] sort keys #1666
Closed
[wip] sort keys #1666
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
📢 Thoughts on this report? Let us know! |
CodSpeed Performance ReportMerging #1666 will improve performances by 38.6%Comparing Summary
Benchmarks breakdown
|
precommits and consistent stubs
zzstoatzz
commented
Mar 10, 2025
Comment on lines
+32
to
+36
| pyo3 = { version = "0.23.5", features = [ | ||
| "generate-import-lib", | ||
| "num-bigint", | ||
| "py-clone", | ||
| ] } |
There was a problem hiding this comment.
prob IDE idiosyncracy, can revert
|
closing in favor of #1637 |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
adds
sort_keysa lajson.dumpstoto_json/to_python_jsonablenot sure if this is the best place to do this, opening for criticism / feedback - happy to work through clean up if im on the right track
seems like i'd need to add a little coverage for rust if this is not otherwise fundamentally flawed
related to pydantic/pydantic#7424
ope I totally missed #1637 lol, happy to close and consolidate there if desirable